Update to latest proto files #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 10 files ± 0 10 suites ±0 21s ⏱️ -10s Results for commit 2abee34. ± Comparison against base commit 5ade5a6. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
csjall
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This PR in ni-apis made a few tweaks to these proto files. I'm reflecting those changes here because there were a few changes to functionality that I'd like to get sorted out now. Soon, these protos will be sourced from ni-apis, but I'd like that change to be as simple as a possible when it happens.
This PR makes these changes:
panel_uriis nowpanel_url. No change in functionality, just a renamepanel_script_pathis nowpanel_script_url. That also means it should be "file://c:/panel.py" instead of just "c:/panel.py"python_pathis nowpython_interpreter_url. That also means it should be "file://c:/python.exe" instead of just "c:/python.exe"The corresponding changes to the server are here.
Why should this Pull Request be merged?
We want the proto files to be up to date.
What testing has been done?